Correctly implement relaxed comparison for UsfmTextUpdater #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enkidu93
reviewed
May 31, 2024
There was a problem hiding this comment.
Sorry, took me a bit since I hadn't been tracking the logic along the way.
Reviewed all commit messages.
Reviewable status: 0 of 6 files reviewed, all discussions resolved
ddaspit
force-pushed
the
relaxed-scripture-ref
branch
from
0c849a7
to
a69afa9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #204 +/- ##
==========================================
- Coverage 67.33% 67.31% -0.02%
==========================================
Files 441 441
Lines 35004 35001 -3
Branches 4695 4695
==========================================
- Hits 23569 23560 -9
- Misses 10346 10352 +6
Partials 1089 1089 ☔ View full report in Codecov by Sentry. |
|
@Enkidu93 Can you approve the PR in Reviewable? Thanks. |
Enkidu93
approved these changes
May 31, 2024
There was a problem hiding this comment.
Sorry about that - thought I had. Thank you!
Reviewed 6 of 6 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ddaspit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is