Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical placement of section head text (with borders) depends on whether it has descenders or not #402

Closed
jeffheath-sil opened this issue Feb 19, 2021 · 4 comments
Labels
Fixed? We think the bug has been fixed in the repository version, but awaiting confirmation from reporter

Comments

@jeffheath-sil
Copy link

When I put a border around a section heading, I’m seeing that the text is placed differently within the border if it doesn’t have any descenders. For example, look at the difference in vertical position in the text of these two borders:

image

The borders are being placed consistently, but a section head text without descenders is placed much lower.

This does bad things when the section head is at the top of a page, because a section head with descenders appears fine:

image

But for a section head without descenders, XeTeX thinks it has room enough to fit the section head on one line:

image

@mhosken
Copy link
Collaborator

mhosken commented Feb 19, 2021

Fixed the top of page issue. More thought needed on the descenders problem.

@mhosken
Copy link
Collaborator

mhosken commented Feb 22, 2021

Added a legacy compatibility option to use glyphmetrics for line heights. Disable this to get what you want.

@mhosken mhosken added the Fixed? We think the bug has been fixed in the repository version, but awaiting confirmation from reporter label Feb 22, 2021
@jeffheath-sil
Copy link
Author

In case anyone else is looking for it... It's on the Advanced tab, in the Compatibility box. And that seems to take care of the problem.

The pop-up for this new option says this:
image

That sort of begs the question... If font metrics gives more consistent results, why would you use glyph metrics? I'm OK leaving it in (with this option), but I just thought I'd ask.

And assuming you do The Right Thing with that question, as far as I'm concerned you can close this issue.

@markpenny
Copy link
Collaborator

Here's how I understand it working...

For any new projects, it will automatically default to the better way of working (i.e. that option to "Use glyph metrics" will default to being OFF). But in order to not break everything for everyone else, existing projects will continue to use the legacy "glyph metrics" - so that box will stay checked for them. But they are free to uncheck it...

Does that make sense as to why it is ON for you? But hopefully OFF for anyone starting out fresh...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed? We think the bug has been fixed in the repository version, but awaiting confirmation from reporter
Projects
None yet
Development

No branches or pull requests

3 participants