Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New font and css fixes #831

Merged
merged 1 commit into from Apr 3, 2024
Merged

Conversation

onespaceman
Copy link
Contributor

Fix tooltip colors in dark mode
Change font to jetbrains mono
Preview - styling fixes and follow editor font

@zefhemel
Copy link
Collaborator

Thanks for doing this. Now I need some adjusting time. From the screenshots it looked good. Now that it's "real" and I can test it, I have to get used to this new font after looking at iA Writer's for 2 years 😆

@zefhemel
Copy link
Collaborator

For those who want to have a look at the difference:

CleanShot 2024-03-26 at 21 02 59

@zefhemel
Copy link
Collaborator

zefhemel commented Apr 3, 2024

Ok let's try. We can always revert.

@zefhemel zefhemel merged commit f193a73 into silverbulletmd:main Apr 3, 2024
1 check passed
@zefhemel
Copy link
Collaborator

zefhemel commented Apr 8, 2024

I've been using this for a few days or a week and... not in love to be honest. Maybe I'll revert this. Or somehow we make this an option. Maybe there's a way to serve font files from a space directly so it's easier for people to use their own non-default fonts 🤔

@paletochen
Copy link
Contributor

I've been using this for a few days or a week and... not in love to be honest. Maybe I'll revert this. Or somehow we make this an option. Maybe there's a way to serve font files from a space directly so it's easier for people to use their own non-default fonts 🤔

Same here,
It is not the experience I was expecting. I have been using JetBrains Mono for years in my terminal but i cannot make it work (to my eyes) in SB.

I like the original one more

@onespaceman
Copy link
Contributor Author

I have no opinion on the change because I'm using my own font with space style
@import url("https://github.com/iosevka-webfonts/iosevka-term/blob/main/iosevka-term.css");
Google fonts can also be imported this way. Is that a good enough solution?

zefhemel added a commit that referenced this pull request Apr 9, 2024
@zefhemel
Copy link
Collaborator

zefhemel commented Apr 9, 2024

I ended up reverting the font aspect of this in 82e431d

Still appreciate the effort of doing this though! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants