Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CmakeLists.txt for VS 2019 #42

Open
Selora opened this issue Oct 27, 2020 · 0 comments
Open

Fix CmakeLists.txt for VS 2019 #42

Selora opened this issue Oct 27, 2020 · 0 comments

Comments

@Selora
Copy link

Selora commented Oct 27, 2020

Hey there,
I'm too lazy to make a pull request. In order to make this work with VS2019, the following should be added to CMakeLists.txt in ./RpcCore:

if(${CMAKE_GENERATOR} MATCHES "Win64")

to:

if(${CMAKE_GENERATOR} MATCHES "Win64")
            AddRpcCore(${Dir})
elseif(${CMAKE_GENERATOR_PLATFORM} MATCHES "x64")
	    AddRpcCore(${Dir})

Edit:
The following line should be used when building the project:
cmake -G"Visual Studio 16 2019" -A x64 ../../

This is all because they introduced a new semantic in CMAKE for VS2019.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant