Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new snippets #25

Merged
merged 30 commits into from
May 24, 2024
Merged

Add new snippets #25

merged 30 commits into from
May 24, 2024

Conversation

Toby-Masters-SF
Copy link
Contributor

@Toby-Masters-SF Toby-Masters-SF commented Aug 25, 2023

Description

Update readme with details of drops

Fixes #5 (#5)

Type of change

  • Bug fix
  • New feature
  • Breaking change

Checklist

  • README updated (if needed)
  • Version updated (if needed)
  • Changelog updated (if needed)
  • Documentation updated (if needed)

Notes

  • Update currencyconfiguration to include all options
  • Add new radio input!
  • Do Localised filters

@Toby-Masters-SF Toby-Masters-SF linked an issue Aug 25, 2023 that may be closed by this pull request
@Woetfin Woetfin added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 1, 2023
Copy link
Contributor

@Woetfin Woetfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation looks good, but you forgot to add the actual snippets in snippets/liquid-template-snippets.json 😅

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Woetfin Woetfin changed the title 5-add-new-snippets Add new snippets Apr 3, 2024
@Toby-Masters-SF Toby-Masters-SF marked this pull request as draft April 3, 2024 18:06
@Toby-Masters-SF Toby-Masters-SF marked this pull request as ready for review April 25, 2024 13:42
Copy link
Contributor

@Woetfin Woetfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the comments on the snippets code

snippets/liquid-template-snippets.json Outdated Show resolved Hide resolved
snippets/liquid-template-snippets.json Outdated Show resolved Hide resolved
snippets/liquid-template-snippets.json Outdated Show resolved Hide resolved
snippets/liquid-template-snippets.json Outdated Show resolved Hide resolved
snippets/liquid-template-snippets.json Show resolved Hide resolved
snippets/liquid-template-snippets.json Outdated Show resolved Hide resolved
snippets/liquid-template-snippets.json Outdated Show resolved Hide resolved
snippets/liquid-template-snippets.json Outdated Show resolved Hide resolved
snippets/liquid-template-snippets.json Outdated Show resolved Hide resolved
"body": ".star",
"description": "Return all starred reconciliations - must use with variable of type reconciliations (drop)"
},
"Reconciliation star drop (with options)": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be starred? ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to just be 'starred' per guidance? (https://developer.silverfin.com/docs/reconciliations), but have otherwise updated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I was looking at the ReconciliationDrop (https://developer.silverfin.com/docs/reconciliation) instead of the ReconciliationsDrop

"prefix": "date: YYYY-MM-DD",
"body": "| date:\"%F\"",
"description": [
"ISO date formatting (DD/MM/YYYY).\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description should still be updated here as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

"Date filter - DD/MM/YYYY format": {
"prefix": "date: DD/MM/YYYY",
"body": "| date:\"%d/%m/%Y\"",
"description": "Standard BE date formatting (DD/MM/YYYY)."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description should still be updated here as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

"body": ".star",
"description": "Return all starred reconciliations - must use with variable of type reconciliations (drop)"
},
"Reconciliation star drop (with options)": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I was looking at the ReconciliationDrop (https://developer.silverfin.com/docs/reconciliation) instead of the ReconciliationsDrop

Copy link
Contributor

@Woetfin Woetfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but the rest look good and can go live once the last few things are updated

@Woetfin
Copy link
Contributor

Woetfin commented May 24, 2024

Don't forget to also still bump the version in package.json to 1.17.0, run npm install to update the package-lock.json and update the changelog.md before packaging it for release

@Toby-Masters-SF Toby-Masters-SF merged commit dc88b8c into main May 24, 2024
@Toby-Masters-SF Toby-Masters-SF deleted the 5-add-new-snippets branch May 24, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new snippets
2 participants