Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node to 12.14.0 and NPM to 6.13.4, add @silvermine/standardization #5

Merged
merged 2 commits into from Nov 27, 2020
Merged

Update Node to 12.14.0 and NPM to 6.13.4, add @silvermine/standardization #5

merged 2 commits into from Nov 27, 2020

Conversation

pbredenberg
Copy link
Contributor

No description provided.

@pbredenberg pbredenberg force-pushed the pbredenberg/upgrade-node branch 4 times, most recently from c79f9b6 to 553c74e Compare November 20, 2020 16:45
@coveralls
Copy link

coveralls commented Nov 20, 2020 •
edited

Pull Request Test Coverage Report for Build 23

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 15: 0.0%
Covered Lines: 8
Relevant Lines: 8
💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 20, 2020 •
edited

Pull Request Test Coverage Report for Build 21

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 15: 0.0%
Covered Lines: 8
Relevant Lines: 8
💛 - Coveralls

@pbredenberg
Copy link
Contributor Author

@jthomerson ready for you

jthomerson
jthomerson requested changes Nov 26, 2020
View reviewed changes
Copy link
Member

@jthomerson jthomerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one question.

.editorconfig Outdated
@@ -0,0 +1,9 @@
[*]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbredenberg aren't we usually making this a symlink to the file in the standardization repo (i.e. node_modules/@silvermine/standardization/.editorconfig) so that it's not duplicated everywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did it! @jthomerson back to you

@jthomerson jthomerson merged commit 936a690 into silvermine:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthomerson jthomerson jthomerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbredenberg @coveralls @jthomerson