Skip to content

Commit

Permalink
ci: move check-node-version to separate step
Browse files Browse the repository at this point in the history
  • Loading branch information
onebytegone committed May 3, 2024
1 parent 0a45d65 commit d1d4da3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
node-version-file: '.nvmrc'
- run: npm i -g npm@10.5.0
- run: npm ci
- run: npm run check-node-version
- run: npm run standards
test:
needs: [ build ]
Expand All @@ -31,8 +32,7 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm i -g npm@10.5.0
- run: npm ci # Reinstall the dependencies to ensure they install with the current version of node
- run: npm ci # Reinstall the dependencies to ensure they install with the node's version of npm
- run: npm test
- name: Coveralls
uses: coverallsapp/github-action@v1
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"version": "2.4.0",
"description": "eslint plugins to support our JS Code Standards. See @silvermine/eslint-config-silvermine",
"scripts": {
"test": "check-node-version --npm 10.5.0 && nyc mocha -- 'tests/**/*.test.js'",
"check-node-version": "check-node-version --npm 10.5.0",
"test": "nyc mocha -- 'tests/**/*.test.js'",
"commitlint": "commitlint --from 2317166",
"eslint": "eslint .",
"markdownlint": "markdownlint -c .markdownlint.json -i CHANGELOG.md '{,!(node_modules)/**/}*.md'",
Expand Down

0 comments on commit d1d4da3

Please sign in to comment.