Refs #20 Upgrade to eslint v4 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will likely require a version bump to v2 since the update to eslint 4 can be considered a breaking change. |
jimjenkins5
force-pushed
the
fix_upgradeToEslint4_20
branch
from
9c8cbb0
to
d077f3a
Compare
jimjenkins5
changed the title
In eslint v4 there were some breaking changes in relation to comments that broke our fluent chaining rule. This commit fixes that issue and bumps the dependency on eslint to v4.15.0.
jimjenkins5
force-pushed
the
fix_upgradeToEslint4_20
branch
from
d077f3a
to
7d78ff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In eslint v4 there were some breaking changes in relation to comments
that broke our fluent chaining rule. This commit fixes that issue and
bumps the dependency on eslint to v4.15.0.