feat: add PropsWithType to get all property names that are of a given type #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onebytegone
force-pushed
the
add-props-with-type
branch
from
868a8f0
to
2fe9e82
Compare
onebytegone
changed the title
jthomerson
requested changes
Sep 11, 2019
|
|
||
| let obj: TestType = { prop: 'test', anotherProp: 1, additionalProp: 2 }; | ||
|
|
||
| expect(getNumber(obj, 'anotherProp')).to.strictlyEqual(1); |
There was a problem hiding this comment.
ADIRL: it'd be nice to actually validate that getNumber(obj, 'prop') and getNumber(obj, 'doesNotExist') both fail.
There was a problem hiding this comment.
I think something like dtslint has promise for this type of testing. I've pushed a WIP example here. However, as that will be more work to implement, I vote we do that work in a later PR.
|
@onebytegone also, your commit message failed commitlint |
onebytegone
force-pushed
the
add-props-with-type
branch
from
2fe9e82
to
249ddca
Compare
jthomerson
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.