build: allow for broader versions of tslib peer dependency #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @onebytegone |
onebytegone
requested changes
Jul 14, 2022
package.json
Outdated
| @@ -33,7 +33,7 @@ | |||
| "type guards" | |||
| ], | |||
| "peerDependencies": { | |||
| "tslib": "1.9.x" | |||
| "tslib": ">= 1.9.0 < 2" | |||
There was a problem hiding this comment.
Does this work? According to https://semver.npmjs.com/ it seems to be compatible.
Suggested change
| "tslib": ">= 1.9.0 < 2" | |
| "tslib": "^1.9.0" |
It's generally good practice to make peer dependencies as lenient as possible so that they are compatible with other packages that share that same peer dependency, as mentioned here: https://nodejs.org/en/blog/npm/peer-dependencies/
lukelafountaine
force-pushed
the
ldlafountaine/allow-wider-peer-deps
branch
from
f743c0b
to
3b0b0f1
Compare
onebytegone
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package currently is not compatible with another package that my project depends on. The change in this MR should allow the toolbox to work with a broader number of other packages that list
tslibas a peer dependency.