fix: Remove target availability event listener on dispose (#29) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yokuze
requested changes
Feb 10, 2022
izkmdz
force-pushed
the
ismendoza/fix-dispose-listener
branch
2 times, most recently
from
52bb4e2
to
d20dc68
Compare
izkmdz
force-pushed
the
ismendoza/fix-dispose-listener
branch
from
9865dbb
to
61bb196
Compare
yokuze
reviewed
Feb 23, 2022
src/js/components/AirPlayButton.js
Outdated
| if (event.availability === 'available') { | ||
| self.show(); | ||
| } else { | ||
| self.hide(); | ||
| } | ||
| } | ||
|
|
||
| mediaEl.addEventListener('webkitplaybacktargetavailabilitychanged', onTargetAvailabilityChanged, this); |
There was a problem hiding this comment.
One other thing I missed in the previous review: The third parameter to the addEventListener method is either an options object or a boolean flag, not a reference to this: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener
We should just remove the third parameter here and below. The onTargetAvailabilityChanged handler has access to the proper this via the self variable.
) Fix for issue silvermine#29. This commit removes the "webkitplaybacktargetavailabilitychanged" event listener when the component is disposed. It also provides a test case demo in which the user can remove (dispose) the AirPlay component from the videoJS player.
izkmdz
force-pushed
the
ismendoza/fix-dispose-listener
branch
from
61bb196
to
ea0880d
Compare
yokuze
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #29.
This commit removes the "webkitplaybacktargetavailabilitychanged" event listener when the component is disposed. It also provides a test case demo in which the user can remove (dispose) the AirPlay component from the videoJS player.