New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assertive TinyOrmConfig.cmake breaks static builds #21
Comments
I want to ask, are these static builds working? I don't mean installation but if you can execute it correctly and on what OS are you building? |
I'm not sure about TinyORM's primary ORM capabilities, but the querybuilder works in static linkage mode... on Debian, Manjaro, and FreeBSD. I'll try Windows later |
Great to hear, the querybuilder is most important. The ORM is header only so that should be ok too but in C++ anything can happen. |
Also, I don't personally use static builds but always shared. |
static builds of TinyORM work on windows, too (requires #18 though, as a linker warning breaks the build due to |
I have tried CMake static build with Qt6 msvc now and I was successful, no fails. |
Tried with BUILD_SHARED_LIBS=OFF, TOM_EXAMPLE=ON, BUILD_TESTS=ON, MYSQL_PING=ON, also all tests passed so this should be ok. |
I'm not getting any warnings on my workstation either, however I'm seeing them occur on the github runners. Appearently the warnings are gone on github, too, after updating TinyORM from 0.33.0 to 0.34.0 . |
Thank you, merged, also pls merge |
When searching for a TinyORM installation via
find_package(TinyORM)
, theTinyORMConfig.cmake
script generated from cmake/TinyOrmConfig.cmake.in will assert on the existance of${TinyORM_ROOT}/bin
in line 21 of it's source script and store the result into a variable that isn't referenced by the find_package logic.If a static-only TinyORM is installed, the corresponding path will not be created during installation as the static library resides in
lib
rather thenbin
, causingfind_package
invokations by consuming projects to fail.The text was updated successfully, but these errors were encountered: