Names on shipping and billing address will now default to the main order names #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $address = $this->Member()->{"Default${type}Address"}(); | ||
| } | ||
|
|
||
| if (empty($address->Surname) && empty($address->FirstName)) { |
There was a problem hiding this comment.
Should this check/assign each field separately?
There was a problem hiding this comment.
I don't think so. If, for example they the shipping address had only the last name (which I've seen happen), we wouldn't want it to then inject the first name from the order because the customer probably did that for a reason. I think we only want it to inject if both fields are empty.
markguinn
pushed a commit
that referenced
this pull request
Feb 26, 2016
Names on shipping and billing address will now default to the main order names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.