Added logic to prevent upscaling product images #495
Conversation
|
@bummzack - could you give this a quick review? Do you see any problems with doing this? |
| return $this->owner; | ||
| } | ||
|
|
||
| $dim = explode('x', $this->owner->getDimensions()); |
There was a problem hiding this comment.
Why not use $this->owner->getWidth() and $this->owner->getHeight()?
There was a problem hiding this comment.
The main reason is to not have it run the calculations twice. Last time I checked the dimensions were not cached in any way.
There was a problem hiding this comment.
Is the string concatenation/explode via getDimensions really faster than two individual calls for getHeight and getWidth?
I'd rather have better readable and more stable code (what if the joining string changes from x to × or something else?). Using getWidth and getHeight is also in line with what is being used in the framework code (look at the usage of getWidth and getHeight vs. getDimensions)
No description provided.