Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where newly created member wasn't logged in after completing an order. #632

Merged
merged 1 commit into from
Feb 12, 2018

Conversation

bummzack
Copy link
Collaborator

Fix issue with a PHP error showing up after logout (session was manipulated, but already cleared).

…g an order.

Fix issue with a PHP error showing up after logout (session was manipulated, but already cleared).
@codecov-io
Copy link

Codecov Report

Merging #632 into master will decrease coverage by 0.05%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #632      +/-   ##
============================================
- Coverage     46.52%   46.47%   -0.06%     
- Complexity     1582     1584       +2     
============================================
  Files           119      119              
  Lines          4621     4622       +1     
============================================
- Hits           2150     2148       -2     
- Misses         2471     2474       +3
Impacted Files Coverage Δ Complexity Δ
src/Extension/MemberExtension.php 96.77% <ø> (-0.11%) 10 <0> (ø)
src/Cart/ShoppingCart.php 79.89% <ø> (ø) 72 <0> (ø) ⬇️
src/Checkout/Component/Membership.php 60.24% <100%> (ø) 32 <0> (ø) ⬇️
src/Checkout/OrderProcessor.php 81.52% <100%> (ø) 52 <0> (ø) ⬇️
src/ShopTools.php 74.19% <66.66%> (-1.67%) 16 <7> (+2)
src/Extension/OrderManipulationExtension.php 46.87% <0%> (-3.13%) 24% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953e73b...a165067. Read the comment docs.

@bummzack bummzack merged commit 8433d08 into silvershop:master Feb 12, 2018
@bummzack bummzack deleted the pulls/fix-session-issue branch February 12, 2018 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants