Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "ShopEmail" injector setting. #641

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

bummzack
Copy link
Collaborator

Change the OrderEmailNotifier accordingly.
Change debug output of emails, so that the ShopEmailPreviewTask is usable.

Change the OrderEmailNotifier accordingly.
Change debug output of emails, so that the ShopEmailPreviewTask is usable.
@codecov-io
Copy link

Codecov Report

Merging #641 into master will decrease coverage by 0.08%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #641      +/-   ##
============================================
- Coverage     46.97%   46.89%   -0.09%     
- Complexity     1561     1564       +3     
============================================
  Files           115      115              
  Lines          4534     4544      +10     
============================================
+ Hits           2130     2131       +1     
- Misses         2404     2413       +9
Impacted Files Coverage Δ Complexity Δ
src/Checkout/OrderEmailNotifier.php 70.58% <50%> (-6.59%) 20 <1> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f2fd09...b799e1e. Read the comment docs.

@bummzack bummzack merged commit 48fdf81 into silvershop:master Feb 23, 2018
@bummzack bummzack deleted the pulls/emails branch February 23, 2018 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants