Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nojquery js for addressbook display logic #790

Merged
merged 1 commit into from Sep 27, 2023
Merged

Added nojquery js for addressbook display logic #790

merged 1 commit into from Sep 27, 2023

Conversation

BettinaMaria98
Copy link
Contributor

  • Added js file with vanilla javascript to avoid using jquery.
  • Updated AddressBook Component to load CheckoutPage.nojquery.js file instead jquery if no jquery file is defined.

@wilr wilr merged commit 51e8d2a into silvershop:master Sep 27, 2023
2 checks passed
@wilr
Copy link
Contributor

wilr commented Sep 27, 2023

Thanks! Great, nowadays we could probably drop the jQuery one, not sure what benefit that provides over plain js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants