M lindenhofer fix variations sort bug #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add $removecount and $updatecount to extension point to make it possible to create session messages in singular form
…php as it is no longer supported in CMS5. Add sort call to getFormFields-Method in VariationForm.php
Change notation of sort-params
|
Thanks a lot for this PR. You're now listed at https://github.com/silvershop/silvershop-core/graphs/contributors 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove sort-method call with RAW SQL from ProductVariationsExtension.php as it is no longer supported in CMS5 to fix error caused by that. Moved the sorting to getFormFields()-Method in VariationForm.php instead