Fix $this->addresstype only contains EN value #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update AddressBook translation string by adding the addresstype - for SS4 version
as $this->addresstype only returns the hardcoded string in english language. There is now a variable which holds the translated string for each type
…TypeFix Update AddressBook.php - Fix
wernerkrauss
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Update AddressBook.php SS4 Update AddressBook translation string by adding the addresstype - for SS4 version * Update AddressBook.php - Fix as $this->addresstype only returns the hardcoded string in english language. There is now a variable which holds the translated string for each type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I provided a new variable which now holds the translated AddressType for types Billing and Shipping. The default EN value remains as fallback as there were customizations made, like renaming the type in an extension