-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work in progress: Add ability to link/unlink existing records #13
Conversation
@mlewis-everley This package hasn't had a commit in quite a while, so I've created a fork that has some extra functionality and also merged in your PR with some refactoring at hchokshi/silverstripe-hasonefield. It's marked as a composer replacement for this package under |
@hchokshi, Cool! I have been meaning to look into this in more detail, so I will try and check it out ASAP. I think this repo is low priority, but it is still maintained by @bummzack and @wilr (at least as far as I am aware). If your changes have finished off what I was doing, maybe you could submit a PR back to this repo and one of those guys might be able to merge it in? |
@hchokshi long term did you want to PR your changes back here or do you want us to redirect this repo to your version? |
@wilr I'm happy to PR this back. There is a breaking change in this commit - hchokshi@b7033ed If you guys are OK with issuing a new major version with this change, I'll revert my composer vendor/replaces changes and PR this in? |
Yep I'll tag a release prior to merge and start a new release line with your version. |
Unfortunately I am still unable to get this PR request finished. @wilr (as you are about) any idea how I can make the parent EditForm reload after linking/unlinking an existing record? |
@mlewis-everley I merged your commits into my fork and fixed that reload issue (a962987). |
Awesome work @hchokshi |
Thanks @wilr. Also nice work @mlewis-everley 😃 |
@hchokshi OK, thanks, I think I can see your fix (although I tried this and couldn't seem to get it working). You seem to have removed the link existing button though (which was also part of this PR)? |
This module works great, but you cannot link existing records (or unlink a record once linked).
This PR lays some of the groundwork, but I am am now kind of stuck...
Basically, the
GridFieldAddExistingAutoCompleter
and the newGridFieldHasOneUnlinkButton
work, but they do not force theGridField
to reload (or possibly, theGridField
is not properly updated on reload).I was wondering if you guys might have some insight? I am assuming you would like to add this functionality (to me it makes sense to be able to link/unlink as well as just add new)?