Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Update to composer v2 #256

Closed
chillu opened this issue Nov 18, 2020 · 4 comments
Closed

Update to composer v2 #256

chillu opened this issue Nov 18, 2020 · 4 comments

Comments

@chillu
Copy link
Member

chillu commented Nov 18, 2020

There seems to be some coupling between running the global composer binary/phar, and including the PHP libraries, as evidenced by this build failure: https://travis-ci.com/github/silverstripe/addons.silverstripe.org/builds/202246360#L463. I'm fixing this now via falling back to v1 in travis.yml

Functionally, it's unclear how long composer v1 will be supported.

@robbieaverill
Copy link
Contributor

We probably need to update those module rating repos to work with Composer 2!

@chillu
Copy link
Member Author

chillu commented Nov 18, 2020

PR at #255, side effect from investigation into OOM errors on prod.

We probably need to update those module rating repos to work with Composer 2!

Done that now: silverstripe/moduleratings-plugin#2. But I've also removed the dependency from addons, we don't seem to need the composer plugin, just silverstripe/moduleratings which doesn't have any direct composer dependencies (no upgrade necessary)

@robbieaverill
Copy link
Contributor

robbieaverill commented Nov 19, 2020

Yep, you're right. The plugin is there so you can run the module rating commands in the addons project from the command line, if you want to test it. I also used the plugin to moduleratings library when I was building it. You can remove it and use BuildTasks instead though.

@chillu
Copy link
Member Author

chillu commented Nov 19, 2020

Merged and pushed to prod

@chillu chillu closed this as completed Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants