MNT Remove TODO comments #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
commented
Oct 16, 2023
sabina-talipova
commented
Oct 16, 2023
| /** | ||
| * @todo rename file to match class name | ||
| * @todo investigate updated HTMLEditorField_Toolbar changes, and find new implementation | ||
| */ |
There was a problem hiding this comment.
Open ticket: #127
sabina-talipova
commented
Oct 16, 2023
| @@ -10,8 +10,6 @@ | |||
| use SilverStripe\View\Requirements; | |||
|
|
|||
| /** | |||
| * TODO: describe. | |||
There was a problem hiding this comment.
Open ticket: #127
sabina-talipova
commented
Oct 16, 2023
| @@ -6,7 +6,6 @@ | |||
| * CwpAtomFeed class | |||
| * | |||
| * This class is used to create an Atom feed. | |||
| * @todo Improve documentation | |||
There was a problem hiding this comment.
Open ticket: #127
sabina-talipova
commented
Oct 16, 2023
There was a problem hiding this comment.
LoginAttemptNotifications extension is currently disabled.
sabina-talipova
commented
Oct 16, 2023
| @@ -16,7 +16,6 @@ SilverStripe\Security\Group: | |||
| extensions: | |||
| - CWP\Core\Extension\CwpHtmlEditorConfig | |||
|
|
|||
| # @todo investigate replacement for this | |||
There was a problem hiding this comment.
Open ticket: #128
GuySartorelli
requested changes
Oct 24, 2023
sabina-talipova
force-pushed
the
pulls/3.0/remove-todo
branch
from
b9936b2
to
be5d86e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue