Update version label on site summary report for CWP #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NightJar
approved these changes
May 23, 2018
ScopeyNZ
force-pushed
the
pulls/1/extend-site-summary-report
branch
from
92e038a
to
7d7ce26
Compare
robbieaverill
suggested changes
May 23, 2018
| * - Adding CWP | ||
| * - Relabelling SS CMS | ||
| * | ||
| * @param $modules |
| $modules = ['cwp/cwp' => 'CWP'] + $modules; | ||
| $modules['silverstripe/cms'] = 'SilverStripe CMS'; | ||
| } | ||
| } |
There was a problem hiding this comment.
PSR-2 mandates an empty line at the end of each file =)
…y" report to display a more appropriate version label
ScopeyNZ
force-pushed
the
pulls/1/extend-site-summary-report
branch
from
7d7ce26
to
7c86995
Compare
robbieaverill
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new "Site Summary" report being adding in silverstripe-maintenance, this PR updates the version label displayed to show the CWP version instead of the SilverStripe framework version
Related to bringyourownideas/silverstripe-maintenance#35