Use tar to validate what files are in the DataArchive
#152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stojg Tests fail because you used short-hand array syntax. Probably should fix to the traditional syntax until we ditch 5.3 support in framework. |
| $archive->ArchiveFile()->Filename = __DIR__.'/sspaks/assets.sspak'; | ||
| $result = $archive->validateArchiveContents('db'); | ||
| $this->assertFalse($result->valid()); | ||
| $this->assertEquals('The snapshot is missing the database.', $result->messageList()[0]); |
There was a problem hiding this comment.
It's actually these guys failing the tests
stojg
force-pushed
the
quicker-validate-archive
branch
from
734d649
to
f75a62c
Compare
This speeds up the validation process immensely when dealing with multiple GB snapshots and doesn't use any more diskspace
stojg
force-pushed
the
quicker-validate-archive
branch
from
f75a62c
to
1fe1a41
Compare
|
Finally the test passed, I had to bump them until various network failures stopped messing with composer. |
halkyon
pushed a commit
that referenced
this pull request
Jul 1, 2015
Use `tar` to validate what files are in the DataArchive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up the validation process immensely when dealing with multiple GB snapshots and doesn't use any more diskspace