Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injector docs update #105

Merged
merged 1 commit into from Feb 13, 2023
Merged

Conversation

blueo
Copy link
Contributor

@blueo blueo commented Oct 19, 2022

This is an attempt to make the Injector docs more readable/understandable for the uninitiated. Please point out what I've got wrong already :)

Parent issue

@maxime-rainville maxime-rainville mentioned this pull request Oct 19, 2022
2 tasks
@blueo blueo marked this pull request as ready for review November 29, 2022 21:38
@michalkleiner
Copy link
Contributor

@blueo could you please squash the commits into one saying something like "ENH Improve Injector docs" or so. Thanks!

@blueo
Copy link
Contributor Author

blueo commented Dec 8, 2022

done @michalkleiner

Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a ✅ from me but would definitely prefer a check from another core member.

@emteknetnz emteknetnz changed the base branch from 4 to 4.12 February 13, 2023 01:12
@emteknetnz emteknetnz merged commit 6c96df1 into silverstripe:4.12 Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants