Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Edit links return 404 if you're not logged into GitHub #6

Closed
sminnee opened this issue Sep 9, 2012 · 3 comments
Closed

GitHub Edit links return 404 if you're not logged into GitHub #6

sminnee opened this issue Sep 9, 2012 · 3 comments

Comments

@sminnee
Copy link
Member

sminnee commented Sep 9, 2012

This is a tricky one, I'm not sure how to fix it, but it makes for a bad user experience... :-|

If you're not logged into GitHub, and you click one of the edit links, you don't see a 'please log-in page' or 'unauthorized' - you just get a 404.

@sminnee
Copy link
Member Author

sminnee commented Sep 9, 2012

In principle, visiting https://github.com/login?return_to=%2Fsilverstripe%2Fsapphire%2F could be used to tidy this up, but that link only works if you're not logged in. If you are logged in, you get sent to the GitHub homepage.

@sminnee
Copy link
Member Author

sminnee commented Sep 9, 2012

Maybe they'll respond to this... https://twitter.com/sminnee/status/244682554882551809

chillu added a commit to silverstripe/silverstripe-docsviewer that referenced this issue Oct 30, 2013
chillu added a commit to silverstripe/silverstripe-docsviewer that referenced this issue Oct 30, 2013
@chillu chillu closed this as completed in 0af61ad Oct 30, 2013
@chillu
Copy link
Member

chillu commented Oct 30, 2013

@sminnee Presumably twitter hasn't responded, right? I've googled around a bit, don't see any new solutions... added a note about "required github.com login", that's the best we can do really...

GuySartorelli pushed a commit to creative-commoners/doc.silverstripe.org that referenced this issue Jan 30, 2024
Updated note on seperate installation requirements
GuySartorelli pushed a commit to creative-commoners/doc.silverstripe.org that referenced this issue Jan 30, 2024
BUGFIX: fixed non javascript validation. MINOR: Tidied-up formatting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants