-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Edit links return 404 if you're not logged into GitHub #6
Comments
In principle, visiting https://github.com/login?return_to=%2Fsilverstripe%2Fsapphire%2F could be used to tidy this up, but that link only works if you're not logged in. If you are logged in, you get sent to the GitHub homepage. |
Maybe they'll respond to this... https://twitter.com/sminnee/status/244682554882551809 |
@sminnee Presumably twitter hasn't responded, right? I've googled around a bit, don't see any new solutions... added a note about "required github.com login", that's the best we can do really... |
Updated note on seperate installation requirements
BUGFIX: fixed non javascript validation. MINOR: Tidied-up formatting.
This is a tricky one, I'm not sure how to fix it, but it makes for a bad user experience... :-|
If you're not logged into GitHub, and you click one of the edit links, you don't see a 'please log-in page' or 'unauthorized' - you just get a 404.
The text was updated successfully, but these errors were encountered: