Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Check travis-ci.com instead of travis-ci.org #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GuySartorelli
Copy link
Member

fixes #19
travis-ci.org hasn't allowed new builds to run since June 15th 2021 so it doesn't make sense to check it anymore.

This change will require a valid travis-ci.com token in the TRAVIS_CI_TOKEN environment variable.

fixes silverstripe#19
travis-ci.org hasn't allowed new builds to run since June 15th 2021 so it doesn't make sense to check it anymore.
@GuySartorelli
Copy link
Member Author

GuySartorelli commented Sep 20, 2021

The test that's failing is due to a constant in the ScrutinizerCheck not having its visibility declared - it has nothing to do with this PR (see #21)

@Zerogiven
Copy link

You get anything back there? I also had to remove the isset file condition (// Not set up (404) comment)..

@robbieaverill
Copy link
Contributor

Would you mind fixing the phpcs violation? I realise it's in a file that isn't touched by this PR, but it would be helpful

@GuySartorelli
Copy link
Member Author

GuySartorelli commented Apr 20, 2022

@robbieaverill The phpcs violation fix as well as other things which caused issues with the tests after I fixed the violation is all in #21

@GuySartorelli
Copy link
Member Author

I no longer have access to the forked repository to rebase in order to get this green (the PHPCS is fixed in #21 which has been merged)
I can create a new PR if necessary but I think it's obvious the phpcs-related failure has nothing to do with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for travis-ci.com
3 participants