DEP PHP Support in CMS5 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
emteknetnz
force-pushed
the
pulls/3/upgrade-cms5
branch
from
4cc237e
to
fc96bc3
Compare
emteknetnz
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
Unit test error is because it's installing admin 2.0.0-alpha1 - which lack the a return type - https://github.com/silverstripe/silverstripe-admin/blob/2.0.0-alpha1/code/AdminRootController.php#L106
admin 2.x-dev has the return type https://github.com/silverstripe/silverstripe-admin/blob/2/code/AdminRootController.php#L107
So this installation error will go away once we tag admin 2.0.0-beta1. Unit tests on the modules being tested have run elsewhere and will be run once we tag the beta, so I'm OK with merging this one without the unit tests having been run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue