MINOR altered skipTest to be a instance property rather than static

silverstripe · Sep 26, 2011 · 37d197c · 37d197c
1 parent 51affd2
commit 37d197c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/dev/FunctionalTest.php b/dev/FunctionalTest.php
@@ -58,7 +58,7 @@ function session() {
 
 	function setUp() {
 		// Skip calling FunctionalTest directly.
-		if(get_class($this) == "FunctionalTest") self::$skip_test = true;
+		if(get_class($this) == "FunctionalTest") $this->skipTest = true;
 
 		parent::setUp();
 		$this->mainSession = new TestSession();

diff --git a/dev/SapphireTest.php b/dev/SapphireTest.php
@@ -24,7 +24,7 @@ class SapphireTest extends PHPUnit_Framework_TestCase {
 	 *
 	 * @var bool
 	 */
-	private static $skip_test = false;
+	protected $skipTest = false;
 
 	/**
 	 * @var Boolean If set to TRUE, this will force a test database to be generated
@@ -124,10 +124,9 @@ public static function is_running_test() {
 
 	function setUp() {
 		// We cannot run the tests on this abstract class.
-		if(get_class($this) == "SapphireTest") self::$skip_test = true;
+		if(get_class($this) == "SapphireTest") $this->skipTest = true;
 
-		// Ensure we are to run this test case
-		if(self::$skip_test) {
+		if($this->skipTest) {
 			$this->markTestSkipped(sprintf(
 				'Skipping %s ', get_class($this)
 			));