Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Deprecated ScheduledTask and subclasses #1195

Merged
merged 1 commit into from Feb 19, 2013

Conversation

chillu
Copy link
Member

@chillu chillu commented Feb 18, 2013

These classes put configuration concerns in the inheritance hierarchy, making them very inflexible. For example, if the author of some task decides that "yearly" is an adequate frequency, you can't change that in your own project setup. The only advantage those classes have is the fact that you can set up one cron rule for all tasks, but in practice that saves little to no configuration effort.

Base CliController or BuildTask instead, with custom cron job intervals.

Base CliController or BuildTask instead, with custom cron job intervals.
@wilr
Copy link
Member

wilr commented Feb 18, 2013

Makes sense for it to be deprecated. Looks like Travis is having a fit on something unrelated.. Is ScheduledTask not referenced in any documentation?

@chillu
Copy link
Member Author

chillu commented Feb 19, 2013

Nope, completely undocumented as far as markdown goes ;)

chillu added a commit that referenced this pull request Feb 19, 2013
API Deprecated ScheduledTask and subclasses
@chillu chillu merged commit 876c660 into silverstripe:3.1 Feb 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants