Skip to content
This repository has been archived by the owner on Dec 21, 2022. It is now read-only.

Azure AD Support #127

Merged
merged 5 commits into from Jun 25, 2019
Merged

Conversation

JakubDolba
Copy link

Copy link
Contributor

@NightJar NightJar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Neat, thanks :)

@NightJar
Copy link
Contributor

Technically this is an enhancement, I don't see that any of the public APIs have changed. Would you mind re-targeting this PR against the 3 branch please? This would be included in a minor release (i.e. 3.3.0, master is destined to be 4.0.0).

@JakubDolba JakubDolba changed the base branch from master to 3 June 25, 2019 23:27
@JakubDolba JakubDolba force-pushed the feature/ss3-azure-ad-support branch from b441e03 to 829f531 Compare June 25, 2019 23:31
@JakubDolba JakubDolba force-pushed the feature/ss3-azure-ad-support branch from 829f531 to d5f8ca6 Compare June 25, 2019 23:35
@JakubDolba
Copy link
Author

rebased onto 3 (keeping just my commits) ; changed merge target to 3

@NightJar
Copy link
Contributor

The git-fu is strong with this one 😄

@NightJar NightJar merged commit db21264 into silverstripe:3 Jun 25, 2019
@JakubDolba JakubDolba deleted the feature/ss3-azure-ad-support branch June 27, 2019 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants