This repository has been archived by the owner on Dec 21, 2022. It is now read-only.
Upgrade onelogin/php-saml to v3 to support PHP 7.1+ (WIP) #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-rainville
force-pushed
the
pulls/3/make-php7.3-compatible
branch
from
708283f
to
2e8bd1f
Compare
|
I don't actually know without having a proper LDAP set up to test. |
NightJar
suggested changes
Aug 28, 2019
There was a problem hiding this comment.
I expect this will fail. The onelogin library introduced namespaces between v2 and v3.
Fortunately they do not appear to have altered their public API beyond that, and even better the namespaces match the old naming convention of underscores.
e.g. OneLogin_Saml2_Utils becomes OneLogin\Saml2\Utils
See https://github.com/silverstripe/silverstripe-realme/pull/45/files for an example :)
If you wanted to 'cheat' you could probably e.g. use OneLogin\Saml2\Utils as OneLogin_Saml2_Utils; or something :P
madmatt
added a commit
to madmatt/silverstripe-activedirectory
that referenced
this pull request
Oct 22, 2019
|
We EOLfing the module. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've converted the module to use the latest version of
onelogin/php-samland SS3.7.However I didn't manage to set up an active directory for testing. So I don't know for a fact that it works and the test coverage is patchy.
Parent issue