Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LeftAndMain independent of the presence of Versioned module #1050

Open
wants to merge 2 commits into
base: 1
Choose a base branch
from

Commits on Jun 5, 2020

  1. Make LeftAndMain independent of the presence of Versioned module

    LeftAndMain's init() method calls two Versioned methods and this makes it impossible to have the Silverstripe-admin module installed without the Versioned module.
    
    In other parts of the Silverstripe-admin code we have the verification of the presence or absence of the Versioned class, instead in the init() method it is missing.
    
    Please, could you also introduce in the init() method the verification of the presence of the Versioned module in order to install the administrative panel without the Versioned module?
    
    Like in the file commit, for example.
    Alessandro Marotta committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    653fd90 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2020

  1. Update LeftAndMain.php

    indentation correction for travis
    Alessandro Marotta committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    876bfd5 View commit details
    Browse the repository at this point in the history