NEW Show nested DataObjects on a single row in the file used on table #1097
Conversation
| ]; | ||
| $this->extend('updateUsageArray', $arr, $dataObject); |
There was a problem hiding this comment.
This whole approach of looking ->Parent() may be a little pointless in that there's not many (any?) non-page DataObjects that follow this pattern (at least in kitchen-sink). It may be more sense to not look for ->Parent() by default and instead rely on this new extension hook.
There was a problem hiding this comment.
What about File and Folder or TaxonomyTerm? Those come to mind as using the Hierarchy extension which provides has_one Parent.
There was a problem hiding this comment.
Could you please remove the two font-weight's of 500 from your PR? These should just be default which is 400 and will come through automatically. I'll update the designs to showcase this more clearly. Could you please ensure the title is 13px and the description is 11px. I didn't pull down your branch to check but please request another review from me when you're ready for a UX review.
|
@sachajudd sorry I should have updated description. This PR won't get merged as is basically just used as reference for future work, possibly some of it will be copy-pasted. We ended up spinning up a new issue for used on table feature work. I'll close this PR. |
|
Code from this PR has been somewhat moved to #1121 |
Issue #1098
Investigation issue https://github.com/silverstripeltd/product-issues/issues/249
DON'T MERGE YET
build with
yarn devfor now because jest tests haven't yet been updated