New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLN Add missing js translation strings to src/en.json
file
#1702
Conversation
I have one more question. I also found the following string IDs - where do they belong?
and
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic effort, thank you. I'll merge this once CI goes green.
Just as a housekeeping note, please don't tick checkboxes that aren't appropriate to tick - for example you have ticked "CI is green" but there are two failing builds.
It makes it hard to trust that any of the other checkboxes are correctly ticked 😅
Please also link to an open issue, not a closed one. We can't track closed issues.
In this case the CI failures are probably intermittent so I've rerun them.
I have one more question. I also found the following string IDs - where do they belong?
That depends where you found them, and whether they're declared in any other modules or not.
Thanks for taking a look and sorry for my lousiness 🙈 All the string IDs were found in the Also, if the string ID is |
Hm, this file probably also requires to rebuild the bundle. Please help me to sort out the missing string IDs and I'll update the PR 🙏
|
If they're not already declared by other modules, then they will need to be added to the json file. The Maybe open a new separate issue about the ones you're not sure about, and link to where each one is in the code, so we can discuss where they belong without delaying merging this PR which is good to go as-is.
If the module is installed, it will pull the translations from that module. In short: yes ;p
The yaml file for PHP is entirely separate. Unfortunately. |
The JS build failure here is unrelated to the changes in this PR. |
I went through the source code in the `client/src` dir and addded all missing translation strings to the `client/lang/src/en.json` file. Related silverstripe#1689
@GuySartorelli I've updated the PR and added all missing string IDs except the I'm happy with this PR now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for making these changes.
They'll be reflected in transifex next time we do a translations run.
Description
I went through the source code in the
client/src
dir and addded all missing translation strings to theclient/lang/src/en.json
file.Manual testing steps
Issues
Search options
#1689Pull request checklist