ENH Improve loading screen and indicator #582
Conversation
|
NPM test is not happy and cms test is failing (may not be related) |
maxime-rainville
force-pushed
the
pulls/1/load-er-up
branch
from
86815f6
to
e38c213
Compare
|
I've rebased this to see if that fixes the travis build. Is it expected that the logo drawing only occurs once? |
|
@lukereative keen to see this get in :) |
| width: 100%; | ||
| height: 100%; | ||
|
|
||
| &__empty { |
There was a problem hiding this comment.
Should these be -- modifiers rather than __ elements? Seems a bit odd to have .spinner__animation__empty but it might be me and my rudimentary understanding of BEM conventions
There was a problem hiding this comment.
Bump @lukereative, we could get this PR into the next release
There was a problem hiding this comment.
It's a bit ambiguous for this, because these are seperate elements that represent different parts of the logo – they're not 2 states of the same element, so I didn't make them modifiers --.
lukereative
force-pushed
the
pulls/1/load-er-up
branch
from
e38c213
to
af8ed5a
Compare
lukereative
force-pushed
the
pulls/1/load-er-up
branch
from
af8ed5a
to
f50a0ea
Compare
Related PR silverstripe/silverstripe-asset-admin#815