FIX/NEW: Stories are now fetched dynamically from related modules #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #785? |
With one slight caveat - modules still need to opt-in with a file in the root of the module. |
|
Good enough =) nice one |
Cheddam
reviewed
Jul 15, 2019
Cheddam
reviewed
Jul 15, 2019
ScopeyNZ
force-pushed
the
pulls/1.4/dynamic-stories
branch
from
70937d7
to
899814a
Compare
|
I should re-target this at |
Modules that stories need to be gathered from should have a .ss-storybook.js configuration file in their root directory
Co-Authored-By: Robbie Averill <robbie@averill.co.nz>
Caused by trying to realpath a non-existent file. This commit also updates code docs
ScopeyNZ
force-pushed
the
pulls/1.4/dynamic-stories
branch
from
899814a
to
c11d0f3
Compare
|
Ok that's retargetted now. I've addressed the feedback too. Hopefully we can get this merged for modules to use |
robbieaverill
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules that stories need to be gathered from should have a .ss-storybook.js configuration file in their root directory
I'll add some documentation in a framework PR, and then I'll add the
.ss-storybook.jsto asset-admin too.I can rebase this against the minor branch if required but as this is dev changes I thought it'd be nice to have this storybook enhancement in place for fixing bugs or developing features in modules based on admin@1.4
Fixes #785
Related PRs: