Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UploadField error messages #720

Closed
1 task
NightJar opened this issue Jan 15, 2018 · 5 comments
Closed
1 task

UploadField error messages #720

NightJar opened this issue Jan 15, 2018 · 5 comments
Assignees
@flamerohr
Labels
affects/v4 complexity/medium impact/high type/bug
Milestone
Recipe 4.0.2

Comments

@NightJar
Copy link
Contributor

NightJar commented Jan 15, 2018 •
edited by tractorcow
Loading

Granted it's hard to accomodate for every eventuality, however in the example below it's not even entirely obvious there was an error:

capture

I think it would be nicer to have some set of 'default' type of error message, such as

There was a problem uploading your image

which would at least give the user some strong topical feedback.

In this case of the example, it was a 400 - Bad request error from uploading a PNG to a field that only allows ico.

PRs:
@NightJar NightJar changed the title UploadField errors UploadField error messages Jan 15, 2018
@flamerohr flamerohr added this to the Recipe 4.1.0 milestone Jan 15, 2018
@tractorcow tractorcow self-assigned this Jan 22, 2018
@tractorcow
Copy link
Contributor

@NightJar I can't reproduce this issue. On 4.0.x-dev and 4.1.x-dev the error message works fine for me.

image

@tractorcow
Copy link
Contributor

I also can't reproduce the error in 4.0.0 stable.

@tractorcow tractorcow removed their assignment Jan 22, 2018
@tractorcow
Copy link
Contributor

Blocked until reproduction can be provided.

tractorcow pushed a commit to open-sausages/silverstripe-framework that referenced this issue Jan 23, 2018
BUG Better upload error message
b44273d 
Fixes silverstripe/silverstripe-asset-admin#720
@tractorcow tractorcow mentioned this issue Jan 23, 2018
Merged
@tractorcow
Copy link
Contributor

PR silverstripe/silverstripe-framework#7785

@NightJar
Copy link
Contributor Author

Hooray, much better, thank you @tractorcow :)

capture

@tractorcow tractorcow modified the milestones: Recipe 4.1.0, Recipe 4.0.2 Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flamerohr flamerohr

Labels
affects/v4 complexity/medium impact/high type/bug
Projects
None yet
Milestone
Recipe 4.0.2
Development

No branches or pull requests
3 participants
@NightJar @tractorcow @flamerohr