Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Support react-router #204

Merged
merged 1 commit into from
Jul 15, 2016

Conversation

tractorcow
Copy link
Contributor

Also adds breadcrumb view.

image

Merge with silverstripe/silverstripe-framework#5796

@sminnee
Copy link
Member

sminnee commented Jul 14, 2016

@tractorcow we're still getting a test failure on this:

Using Jest CLI v0.9.2, jasmine2, babel-jest
 PASS  client/src/state/schema/tests/SchemaReducer-test.js (17.916s)
 PASS  client/src/state/gallery/tests/GalleryReducer-test.js (24.446s)
 PASS  client/src/state/editor/tests/EditorReducer-test.js (24.804s)
 PASS  client/src/state/queuedFiles/tests/QueuedFilesReducer-test.js (24.445s)
 FAIL  client/src/containers/Gallery/tests/Gallery-test.js
● Runtime Error
Error: Cannot find module 'react-router' from 'Gallery.js'
    at Loader._resolveNodeModule (/home/travis/builds/ss/asset-admin/node_modules/jest-cli/src/HasteModuleLoader/HasteModuleLoader.js:431:11)
    at Object.<anonymous> (/home/travis/builds/ss/asset-admin/client/src/containers/Gallery/Gallery.js:7:46)
    at Object.<anonymous> (/home/travis/builds/ss/asset-admin/client/src/containers/Gallery/tests/Gallery-test.js:12:42)
1 test suite failed, 30 tests passed (30 total in 8 test suites, run time 35.997s)

@tractorcow
Copy link
Contributor Author

I'm looking into this now.

API Add breadcrumbs
@tractorcow
Copy link
Contributor Author

I've pushed up a fix... tests should be passing now. :D

@tractorcow tractorcow added this to the CMS 4.0.0-alpha2 milestone Jul 15, 2016
@sminnee sminnee merged commit d2060ca into silverstripe:master Jul 15, 2016
@tractorcow tractorcow deleted the pulls/4.0/react-router branch July 15, 2016 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants