Update class namespace for campaign admin #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
tractorcow
force-pushed
the
pulls/4.0/campaign-admin-module
branch
from
4a824d6
to
05f25a1
Compare
|
Needs a rebase — looks like it'll become a 1 line change. |
tractorcow
force-pushed
the
pulls/4.0/campaign-admin-module
branch
from
05f25a1
to
0beeaa1
Compare
|
done. |
sminnee
approved these changes
Mar 28, 2017
|
Given the |
|
Damian agrees that we need that dependency, so I've added it here. |
|
OK that's tolerable for now – i.e. doesn't block merge – but a weird piece of coupling. |
|
In the future we can de-couple it with a few class_exists(), or maybe just an extension hook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See silverstripe/silverstripe-framework#6735