FileMigrationHelper does not work with "legacy_filenames: true"

[brettt89]

silverstripe-assets/src/FileMigrationHelper.php

Line 125 in 6b599be

$result = $file->setFromLocalFile(

When running the MigrateFileTask after upgrading from SS3.x to SS4.x, If you have legacy_filenames: true set in your codebase, it will cause the migration to read and write the same file which causes 0 bytes to be written to each file.

This is because the $path and $filename variables being parsed refer to the same file ($path - absolute path of file, $filename - relative path of file) meaning that Flysystem will open up a read handler on $path and then stream its content to $filename which is the same file.

Related PRs

• MINOR When using legacy filename resolve conflicts by keeping existing file #209

[brettt89]

Managed to resolve this issue locally by changing the Conflict resolution in the Helper to "Keep original" rather than "Overwrite" when legacy_filenames is set to true.

silverstripe-assets/src/FileMigrationHelper.php

Line 130 in 6b599be

array('conflict' => AssetStore::CONFLICT_OVERWRITE)

[purplespider]

Thanks, I hit this issue too.

Changing:

silverstripe-assets/src/FileMigrationHelper.php

Line 130 in 6b599be

array('conflict' => AssetStore::CONFLICT_OVERWRITE)

To:
array('conflict' => AssetStore::CONFLICT_USE_EXISTING)
Seems to fix it, but unsure if this would cause any other side effects.

[maxime-rainville]

We've got a PR for 4.4 at #209