ENHANCEMENT Default archive year #320
Conversation
| @@ -736,7 +736,7 @@ public function getArchiveYear() { | |||
| return (int) $year; | |||
| } | |||
|
|
|||
| return null; | |||
| return (int) date('Y'); | |||
There was a problem hiding this comment.
This should be SS_Datetime::now()->Year() so that we can unit test correctly. Can you write a test to ensure this returns the correct year? If you check the test fixtures it should tell you what the current year is.
|
I've left 1 comment. You'll need to fix the failing test so that it returns the expected 200 response now. |
|
@micmania1 working on this now |
If no year is passed, rather than 404 it should grab the latest years posts.
camfindlay
force-pushed
the
feature/defaultarchiveyear
branch
from
52d763c
to
43bb224
Compare
|
@micmania1 passing and checking for a default year but will 404 if the year is invalid. |
ENHANCEMENT Default archive year
|
|
||
| $this->assertEquals(404, $this->getStatusOf($link), 'HTTP Status should be 404'); | ||
| $this->assertEquals(200, $this->getStatusOf($link), 'HTTP Status should be 200'); | ||
| $this->assertEquals(SS_Datetime::now()->Year(), ModelAsController::controller_for($blog)->getArchiveYear(), 'Defaults to current year'); |
There was a problem hiding this comment.
#321 - the date is configured in setUp(). Its always 2013 :)
There was a problem hiding this comment.
Wouldn't that just mean that SS_Datetime::now()->Year(); always returns 2013, so it's ok anyway? :P
There was a problem hiding this comment.
Yeah, but you're testing SS_Datetime::now()->Year() == SS_Datetime::now()->Year(). You might as well not test it.
If no year is passed, rather than 404 it should grab the latest years posts.