Skip to content

Commit

Permalink
Merge pull request #147 from creative-commoners/pulls/1.0/sql-ering-a…
Browse files Browse the repository at this point in the history
…way-on-filters

NEW Adding filters on front-end CKAN App:
  • Loading branch information
NightJar committed Jan 23, 2019
2 parents f5a6ee4 + eb4d6df commit 8e0a6c4
Show file tree
Hide file tree
Showing 19 changed files with 526 additions and 132 deletions.
2 changes: 1 addition & 1 deletion client/dist/js/bundle-admin.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion client/dist/js/bundle.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion client/dist/styles/bundle-admin.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion client/dist/styles/bundle.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 1 addition & 15 deletions client/src/components/CKANDropdownFilter.js
Expand Up @@ -10,8 +10,6 @@ import { FormGroup, Input, Label } from 'reactstrap';
* E.g. "filter 'school_name' by the selected value"
*/
const CKANDropdownFilter = ({
allColumns,
columns,
extraClass,
id,
label,
Expand All @@ -32,19 +30,9 @@ const CKANDropdownFilter = ({
name={`DropdownFilter[${id}][Search]`}
onChange={handleChange}
>
<option />
{ selections.map(value => <option key={value}>{ value }</option>) }
</Input>

<Input
type="hidden"
name={`DropdownFilter[${id}][Columns]`}
value={JSON.stringify(columns)}
/>
<Input
type="hidden"
name={`DropdownFilter[${id}][AllColumns]`}
value={allColumns ? 1 : 0}
/>
</FormGroup>
);
};
Expand All @@ -54,8 +42,6 @@ CKANDropdownFilter.propTypes = {
selections: PropTypes.arrayOf(
PropTypes.oneOfType([PropTypes.string, PropTypes.number])
).isRequired,
allColumns: PropTypes.bool,
columns: PropTypes.arrayOf(PropTypes.string),
extraClass: PropTypes.string,
label: PropTypes.string,
};
Expand Down

0 comments on commit 8e0a6c4

Please sign in to comment.