ENHANCEMENT: Remove unused $controller from lambda function

silverstripe · Apr 4, 2020 · 2bbc280 · 2bbc280
1 parent 9cb96bf
commit 2bbc280
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/code/Controllers/CMSMain.php b/code/Controllers/CMSMain.php
@@ -1674,9 +1674,8 @@ public function ListViewForm()
             'getTreeTitle' => 'HTMLFragment'
         ));
 
-        $controller = $this;
         $columns->setFieldFormatting(array(
-            'listChildrenLink' => function ($value, &$item) use ($controller) {
+            'listChildrenLink' => function ($value, &$item) {
                 /** @var SiteTree $item */
                 $num = $item ? $item->numChildren() : null;
                 if ($num) {
@@ -1687,7 +1686,7 @@ public function ListViewForm()
                     );
                 }
             },
-            'getTreeTitle' => function ($value, &$item) use ($controller) {
+            'getTreeTitle' => function ($value, &$item) {
                 $title = sprintf(
                     '<a class="action-detail" href="%s">%s</a>',
                     Controller::join_links(