-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ORM] Error: Uncaught SS_DatabaseException on specific search string #1452
Comments
Similar issue to silverstripe/silverstripe-framework#3212 perhaps? |
Yes, similar issue, but new proof of concept. :D |
These 2 tests validate that the following bugs have been fixed. silverstripe/silverstripe-framework#3212 silverstripe#1452
I've added a test for this to 4.x-dev and it appears to be fixed; can we confirm that? #2320 |
These 2 tests validate that the following bugs have been fixed. silverstripe/silverstripe-framework#3212 silverstripe#1452
#2320 addressed the issue for SS4. Unfortunately, SilverStripe 3 has entered limited support in June 2018. This means we'll only be fixing critical bugs and security issues for SilverStripe 3 going forward. You can read the SilverStripe Roadmap for more information on our support commitments. |
Required to allow InnoDB usage, see silverstripe/silverstripe-framework#9454. This came up in silverstripe#1452, and wasn't fully addressed. Either we allow boolean mode and all the constraints this brings around special character usage, or we filter out those special characters, which makes boolean mode pointless. You can't just pass arbitrary user input in a power-user function like this. See https://dev.mysql.com/doc/refman/5.6/en/fulltext-boolean.html Context: This used to work for some examples like "foo>*" under MyISAM, presumably because it had a more lenient parser. InnoDB rightfully complains about this now.
This came up in silverstripe/silverstripe-cms#1452, and wasn't fully addressed. Either we allow boolean mode and all the constraints this brings around special character usage, or we filter out those special characters, which makes boolean mode pointless. You can't just pass arbitrary user input in a power-user function like this. See https://dev.mysql.com/doc/refman/5.6/en/fulltext-boolean.html Context: This used to work for some examples like "foo>*" under MyISAM, presumably because it had a more lenient parser. InnoDB rightfully complains about this now.
SS 3.2.0-3.3.1 - standard installation through composer.
Search is enabled using FulltextSearchable::enable();
If search string ends with > e.g. hello> SS throws error:
The text was updated successfully, but these errors were encountered: