Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL segment loading indicator position in the wrong place #1625

Closed
clarkepaul opened this issue Sep 22, 2016 · 4 comments · Fixed by #1716
Closed

URL segment loading indicator position in the wrong place #1625

clarkepaul opened this issue Sep 22, 2016 · 4 comments · Fixed by #1716
Labels
affects/v4 complexity/low impact/low type/bug type/UX

Comments

@clarkepaul
Copy link
Contributor

clarkepaul commented Sep 22, 2016 •
edited by flamerohr

Wasn't quick enough to get a screenshot of it but edit the page name and click outside of the input to see indicator.
pasted_image_22_09_16__3_20_pm
@clarkepaul clarkepaul added this to the CMS 4.0.0-alpha3 milestone Sep 22, 2016
@sminnee sminnee modified the milestone: CMS 4.0.0-alpha3 Sep 29, 2016
@hoKRa1
Copy link
Contributor

hoKRa1 commented Jan 17, 2017

Hi Paul,

Just wondering if you had any visual indicators that could perhaps show where the loading indicator is supposed to be positioned.

Thanks

@clarkepaul
Copy link
Contributor Author

It would be okay to use the existing gif for this issue I would think. I will update all the icons to font-icons at some stage but we don't have a spinning font-icon loading indicator yet.

Old loading gif is here cms/client/dist/images/loading.gif
And it used to appear just before the URL/input I think.
pasted_image_18_01_17__1_00_pm

hoKRa1 added a commit to hoKRa1/silverstripe-cms that referenced this issue Jan 18, 2017
@hoKRa1
fixes load indicator position (fixes silverstripe#1625)
0ce3dd4
@hoKRa1 hoKRa1 mentioned this issue Jan 18, 2017
Merged
@chillu
Copy link
Member

chillu commented Apr 19, 2017

Pointer for how to fix this: This is in admin/pages, and Entwine logic (not React). Check SiteTreeURLSegmentField.js

@clarkepaul
Copy link
Contributor Author

Still an issue and now smaller screen sizes need to also be considered.

tractorcow pushed a commit to hoKRa1/silverstripe-cms that referenced this issue Aug 24, 2017
@hoKRa1
fixes load indicator position (fixes silverstripe#1625)
3700b6a
tractorcow pushed a commit to hoKRa1/silverstripe-cms that referenced this issue Aug 24, 2017
@hoKRa1
fixes load indicator position (fixes silverstripe#1625)
b0512ab
flamerohr added a commit that referenced this issue Aug 24, 2017
@flamerohr
Merge pull request #1716 from hoKRa1/1625-fixed-load-indicator
f15a400 
fixes load indicator position (fixes #1625)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/low impact/low type/bug type/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes load indicator position (fixes #1625) hoKRa1/silverstripe-cms
4 participants
@sminnee @chillu @clarkepaul @hoKRa1