Save Button in File-Field

[ruettenm]

When you save an image the "save Button" from Image-Field is no longer visible.

[kinglozzer]

Same issue as here: silverstripe/silverstripe-framework#2188.

@chillu The fix I put together for this is here: silverstripe/silverstripe-framework#2221. It essentially forces the iframe to re-calculate it's height if there's a validation message present.

P.s. similar issue/fix here: silverstripe/silverstripe-framework#2188 / silverstripe/silverstripe-framework#2222

[micmania1]

This isn't always caused by the validation messages:

Is there any reason why we can't just add a scrollbar (overflow: auto)?

[kinglozzer]

The height is specified inline (as it's calculated in the UploadField JavaScript) on the <iframe> element, as well as the div containing it. Setting overflow-y: scroll on the containing div causes the scroll bar to appear, but it still results in half of the 'save' button being cut off (see below).

In my opinion, if we're putting in the effort to calculate the height of the iframe, we should make sure we're calculating it correctly - it seems wrong to calculate the height, then set overflow: scroll anyway.

@micmania1 I can't seem to re-create your issue above where it's cut off without a validation message. Any steps to reproduce?

[chillu]

I would prefer is we just recalc the size on every iframe load, rather than hard coding assumptions about any DOM elements which might be responsible for a height change. Committed in silverstripe/silverstripe-framework@3422761