Moved image thumbnail style rules to Framework #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for consistent styling of image thumbnails in GridFields
jonom
force-pushed
the
choose-file-thumbnails-3.2
branch
from
f540da6
to
7041a43
Compare
|
@tractorcow this is the CMS part of silverstripe/silverstripe-framework#4441 - would you be able to help me understand why some tests are failing? I had a look but it doesn't seem to be related to what I did in this PR. |
|
Hi @jonom sorry something in framework must have broken the CMS behat tests. I think it's probably something outside of this PR. I'll investigate. |
|
I should have merged this when I merged your CMS changes, sorry. I'll do this now and investigate the test failures. |
tractorcow
pushed a commit
that referenced
this pull request
Aug 2, 2015
Moved image thumbnail style rules to Framework
|
Actually this is likely fixed by silverstripe/silverstripe-travis-support#19 :D |
|
Thanks mate 👍 |
|
Rest of the issues seem to be caused by a framework PR missing a CMS pr at #1241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for consistent styling of image thumbnails in GridFields. This is a companion fix for silverstripe/silverstripe-framework#4441