FIX: Use Hierarchy::prepopulate_numchildren_cache in tree-generation #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
added 2 commits
September 21, 2018 17:55
Only relevant if silverstripe/silverstripe-framework#8380 is avialable, however coded defensively so it can be merged before that PR if needs be. See silverstripe/silverstripe-framework#8379
maxime-rainville
previously requested changes
Sep 25, 2018
code/Controllers/CMSMain.php
Outdated
| Hierarchy::prepopulate_numchildren_cache(SiteTree::class, Versioned::DRAFT); | ||
| } | ||
| $filter = $this->getSearchFilter(); | ||
| SiteTree::singleton()->prepopulateTreeDataCache(null, [ |
There was a problem hiding this comment.
I think we should be consistent here and use $this->config()->get('tree_class') to decide what we are caching.
There was a problem hiding this comment.
Yes that would make sense. singleton($this->config()->get('tree_class')) most likely?
|
We can probably squish this into a single commit |
maxime-rainville
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only relevant if silverstripe/silverstripe-framework#8380 is avialable,
however coded defensively so it can be merged before that PR if needs
be.
See silverstripe/silverstripe-framework#8379
Parent issue