FIX undefined index error in CMS #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
requested changes
Mar 28, 2023
NightJar
force-pushed
the
pulls/4.12/undefined-index
branch
from
d0b2b30
to
1e959f4
Compare
GuySartorelli
requested changes
Mar 28, 2023
code/Model/SiteTree.php
Outdated
| // This method has to be implemented here to satisfy the CMSPreviewable interface. | ||
| // See the actual implementation in CMSEditLinkExtension. | ||
| return $this->extend('CMSEditLink')[0]; | ||
| return $this->extend('CMSEditLink') ?? ''; |
There was a problem hiding this comment.
Suggested change
| return $this->extend('CMSEditLink') ?? ''; | |
| return $this->extend('CMSEditLink')[0] ?? ''; |
Still need to get the 0th result
With the CMS 4.12 update functionality was altered to utilise an Extension to obtain the CMS Edit link for a page, rather than having SiteTree do it internally. Unfortunately the default return case for `extend` (see Extensible) is an _empty_ array. This leave code potentially referencing an array offset that doesn't exist ([0]). PHP 8 is less forgiving that it's predecessors on this kind of behaviour. We should check that the responses from extensions exist before trying to reference them.
NightJar
force-pushed
the
pulls/4.12/undefined-index
branch
from
1e959f4
to
e200364
Compare
|
Is there anything left to do here? |
GuySartorelli
approved these changes
Mar 30, 2023
|
Thanks for restarting the automated test run, it's a relief to see it all pass :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the CMS 4.12 update functionality was altered to utilise an Extension to obtain the CMS Edit link for a page, rather than having SiteTree do it internally. Unfortunately the default return case for
extend(see Extensible) is an empty array. This leaves code potentially referencing an array offset that doesn't exist ([0]). PHP 8 is less forgiving than its predecessors on this kind of behaviour. We should check that the responses from extensions exist before trying to reference them.